Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Run cosa unprivileged #4585

Merged
merged 1 commit into from
Sep 8, 2023
Merged

ci: Run cosa unprivileged #4585

merged 1 commit into from
Sep 8, 2023

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Sep 7, 2023 •
edited
Loading

@jlebon
Copy link
Member

jlebon commented Sep 7, 2023

Hmm IIRC, I don't think you can sudo at all without runAsUser: 0. Probably we should add a unprivshwrap() or something that switches to nonroot first. But for now, it should probably work to just do the cosa build as nonroot?

@cgwalters
Copy link
Member Author

Hmm IIRC, I don't think you can sudo at all without runAsUser: 0

You may be right (if I have to I'll extract the pod yaml and test this manually outside of PRs), but let's see if we can do it this way first, because it aligns more closely with other things (e.g. GH Actions).

But for now, it should probably work to just do the cosa build as nonroot?

Right, will try that next.

@cgwalters cgwalters changed the title ci/jenkins: Drop runAsUser: 0 ci: Run cosa unprivileged Sep 8, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@cgwalters
ci: Workaround virtiofs
908dcb0 
Same as coreos/rpm-ostree#4585
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@cgwalters
ci: Workaround virtiofs
be728e7 
Same as coreos/rpm-ostree#4585
@cgwalters cgwalters mentioned this pull request Sep 8, 2023
Closed
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@cgwalters
ci: Workaround virtiofs
f9eb622 
Same as coreos/rpm-ostree#4585
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@cgwalters
ci: Workaround virtiofs
aab68e6 
Same as coreos/rpm-ostree#4585
@cgwalters
Copy link
Member Author

/override ci/prow/fcos-e2e
Can't affect that

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

In response to this:

/override ci/prow/fcos-e2e
Can't affect that

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

continuous-integration/jenkins/pr-merge — This commit looks good

🎉

cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@cgwalters
ci: Workaround virtiofs
9a21f25 
Same as coreos/rpm-ostree#4585
@jlebon jlebon merged commit 5500157 into coreos:main Sep 8, 2023
13 checks passed
jlebon added a commit to jlebon/ostree that referenced this pull request Sep 9, 2023
@jlebon
ci: Run cosa unprivileged
f94cc9c 
As a workaround for a virtiofs bug:
https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/197

xref coreos/coreos-assembler#3428 (comment)

Just like in coreos/rpm-ostree#4585.
jlebon added a commit to jlebon/ostree that referenced this pull request Sep 9, 2023
@jlebon
ci: Run cosa unprivileged
2fe88f8 
As a workaround for a virtiofs bug:
https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/197

xref coreos/coreos-assembler#3428 (comment)

Just like in coreos/rpm-ostree#4585.
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 10, 2023
@cgwalters
ci: Workaround virtiofs
f2865d3 
Same as coreos/rpm-ostree#4585
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 16, 2023
@cgwalters
ci: Workaround virtiofs
ab5f300 
Same as coreos/rpm-ostree#4585
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 16, 2023
@cgwalters
ci: Workaround virtiofs
ae408ff 
Same as coreos/rpm-ostree#4585
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 17, 2023
@cgwalters
ci: Workaround virtiofs
c2dda78 
Same as coreos/rpm-ostree#4585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @jlebon